You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The framework classes define a __framework_name__ attribute used in multipleplaces that may lead to breakage without warning. From the docs:
Any use of __*__ names, in any context, that does not follow explicitly documented use, is subject to breakage without warning.
Describe the solution you'd like
Protected attributes should use, by convention, a single leading underscore, like
class Framework(EstimatorBase):
_framework_name = None
Describe alternatives you've considered
One could forego the leading single underscore, but it lacks the convention of letting code authors know that the attribute is intended to be protected.
One could use a leading dunder, but the class-private name may have unintended consequences regarding expectation of the existing use in inheritance and name mangling.
Additional context
n/a
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The framework classes define a
__framework_name__
attribute used in multiple places that may lead to breakage without warning. From the docs:Describe the solution you'd like
Protected attributes should use, by convention, a single leading underscore, like
Describe alternatives you've considered
Additional context
n/a
The text was updated successfully, but these errors were encountered: