Skip to content

Created more generic pipeline for text-to-image task #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2025

Conversation

fgbelidji
Copy link

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@arjkesh
Copy link

arjkesh commented Apr 11, 2025

It looks like you'll need to update the corresponding test

from sagemaker_huggingface_inference_toolkit.diffusers_utils import SMAutoPipelineForText2Image

Copy link

@arjkesh arjkesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise lgtm



class SMAutoPipelineForText2Image:
class DiffusionPipelineForText2Image:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to change the class name? Looks like it is only used here in this file, so should be safe.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did so as it was related to the import of the class AutoPipelineForText2Image in diffusers not used anymore. Maybe it would make more sense to name it SMDiffusionPipelineForText2Image

@malav-shastri malav-shastri merged commit 019e859 into aws:main Apr 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants