Skip to content

Resolves #84: Whitelist TopicArn for SNS Publish Operation #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions aws_xray_sdk/ext/resources/aws_para_whitelist.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
{
"services": {
"sns": {
"operations": {
"Publish": {
"request_parameters": [
"TopicArn"
]
}
}
},
"dynamodb": {
"operations": {
"BatchGetItem": {
Expand Down
23 changes: 23 additions & 0 deletions tests/ext/botocore/test_botocore.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,3 +150,26 @@ def test_pass_through_on_context_missing():
assert result is not None

xray_recorder.configure(context_missing='RUNTIME_ERROR')


def test_sns_publish_parameters():
sns = session.create_client('sns', region_name='us-west-2')
response = {
'ResponseMetadata': {
'RequestId': REQUEST_ID,
'HTTPStatusCode': 200,
}
}

with Stubber(sns) as stubber:
stubber.add_response('publish', response, {'TopicArn': 'myAmazingTopic', 'Message': 'myBodaciousMessage'})
sns.publish(TopicArn='myAmazingTopic', Message='myBodaciousMessage')

subsegment = xray_recorder.current_segment().subsegments[0]
assert subsegment.http['response']['status'] == 200

aws_meta = subsegment.aws
assert aws_meta['topic_arn'] == 'myAmazingTopic'
assert aws_meta['request_id'] == REQUEST_ID
assert aws_meta['region'] == 'us-west-2'
assert aws_meta['operation'] == 'Publish'