Disable IMDSv1 from Elastic Beanstalk #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration workflow verify the functionality in AWS Elastic Beanstalk. For AWS security reason we need to disable IMDSv1 from EB environment.
|
Including discussion in this PR for visibility: Since some EB environments were still running and not destroyed correctly (likely due to an issue while running the integration test workflow), can we also update the workflow to ensure that the EB environments being created are always being destroyed correctly regardless of the outcome of the workflow? |
carolabadeer
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration workflow verify the functionality in AWS Elastic Beanstalk. For AWS security reason we need to disable IMDSv1 from EB environment.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.