Include unicode type for annotation values #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 79.36% 79.36%
=======================================
Files 80 80
Lines 3159 3159
=======================================
Hits 2507 2507
Misses 652 652
Continue to review full report at Codecov.
|
|
@pbzweihander Can you address the Git out-of-date issue so we can merge? Thanks! |
pbzweihander
force-pushed
the
unicode-annotation-values
branch
from
5b62680 to
ec31fa2
Compare
|
@willarmiros I rebased with the latest master branch! |
|
Checks are failing due to a new version of pymysql. This will be fixed soon. Thanks @pbzweihander for your contribution! |
|
@pbzweihander Can you sync the PR with the latest branch so that we can get this merged? Thanks! |
pbzweihander
force-pushed
the
unicode-annotation-values
branch
from
ec31fa2 to
7a49326
Compare
|
@srprash I rebased with the latest master branch, and the tests passed, too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The AWS X-Ray documentation says the annotation value can be a unicode type. (https://docs.aws.amazon.com/xray/latest/devguide/xray-sdk-python-segment.html#xray-sdk-python-segment-annotations) But aws-xray-sdk-python does not allow unicode type for annotation values in Python 2. I think this is a bug.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.