Skip to content

py2 fixes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws_xray_sdk/ext/httplib/patch.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def http_response_processor(wrapped, instance, args, kwargs, return_value,
subsegment.put_http_meta(http.URL, xray_data.url)

if return_value:
subsegment.put_http_meta(http.STATUS, return_value.code)
subsegment.put_http_meta(http.STATUS, return_value.status)

# propagate to response object
xray_data = _XRay_Data('READ', xray_data.host, xray_data.url)
Expand Down Expand Up @@ -65,7 +65,7 @@ def http_request_processor(wrapped, instance, args, kwargs, return_value,


def _prep_request(wrapped, instance, args, kwargs):
def decompose_args(method, url, body, headers, encode_chunked):
def decompose_args(method, url, body, headers, encode_chunked=False):
inject_trace_header(headers, xray_recorder.current_subsegment())

# we have to check against sock because urllib3's HTTPSConnection inherit's from http.client.HTTPConnection
Expand Down
2 changes: 1 addition & 1 deletion aws_xray_sdk/ext/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def to_snake_case(name):


# ? is not a valid entity, and we don't want things after the ? for the segment name
def strip_url(url: str):
def strip_url(url):
"""
Will generate a valid url string for use as a segment name
:param url: url to strip
Expand Down