Skip to content

Add patch support for pymysql (pure Python driver) #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 10, 2020

Conversation

aniljaiswal
Copy link
Contributor

@aniljaiswal aniljaiswal commented Apr 7, 2020

Issue #214

Description of changes:
Added patch support for pymysql client library (written in python) for MySQL.

TODO:

  • Add unpatch method
  • Add tests (Use: this)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aniljaiswal aniljaiswal marked this pull request as ready for review April 8, 2020 20:04
@srprash srprash self-requested a review April 9, 2020 13:56
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a minor addition to the test is needed.

@aniljaiswal
Copy link
Contributor Author

@srprash requested changes done. Thanks for picking this up so quickly.

@aniljaiswal aniljaiswal requested a review from srprash April 10, 2020 16:04
aniljaiswal added a commit to aniljaiswal/aws-xray-developer-guide that referenced this pull request Apr 10, 2020
Submitted a PR [#215](aws/aws-xray-sdk-python#215) for adding `pymysql` support to the SDK.
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants