-
Notifications
You must be signed in to change notification settings - Fork 144
Add patch support for pymysql (pure Python driver) #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
requested changes
Apr 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a minor addition to the test is needed.
@srprash requested changes done. Thanks for picking this up so quickly. |
aniljaiswal
added a commit
to aniljaiswal/aws-xray-developer-guide
that referenced
this pull request
Apr 10, 2020
Submitted a PR [#215](aws/aws-xray-sdk-python#215) for adding `pymysql` support to the SDK.
srprash
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
aniljaiswal
added a commit
to aniljaiswal/aws-lambda-developer-guide
that referenced
this pull request
Apr 15, 2020
aniljaiswal
added a commit
to aniljaiswal/aws-xray-developer-guide
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #214
Description of changes:
Added patch support for
pymysql
client library (written in python) for MySQL.TODO:
unpatch
methodBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.