Preserve ServiceName (segment name) when tracing external http services with dynamic urls #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es with dynamic urls
shcherbin
force-pushed
the
support-services-with-dynamic-urls
branch
from
e24d3d7 to
2896bf0
Compare
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
+ Coverage 83.33% 83.41% +0.08%
==========================================
Files 77 77
Lines 2910 2913 +3
==========================================
+ Hits 2425 2430 +5
+ Misses 485 483 -2
Continue to review full report at Codecov.
|
|
Hi @chanchiem, I've noticed you were doing code reviews for other PRs. Could you please have a look at this one? Thanks! |
|
Thank you very much for the pull request! We really appreciate the contribution; however, we've added a push of it ourselves in favor of moving the strip_url call to the http.url field. We are also releasing the fix to version 2.4.3 We will be closing this in favor of PR #192 |
|
Sure. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The changes prevent AWS X-RAY service from creating Cloud Watch metrics (ErrorRate, OkRate, ThrottleRate etc) for each unique URI when tracing a remote service with the dynamic URI segments (e.g. https://example.com/orders/{orderID} )
The traces influx with unique ServiceNames makes the X-RAY Service Map unusable and Cloud Watch daily charges extremely high.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.