Skip to content

Poller threads block main thread from exiting bug #134 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2019
Merged

Poller threads block main thread from exiting bug #134 #144

merged 1 commit into from
Mar 1, 2019

Conversation

chanchiem
Copy link
Contributor

Issue #, if available:
#134

Description of changes:
Set poller threads as daemon threads so they dont block the main thread on exit.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chanchiem
Poller threads block main thread from exiting bug aws#134
da9b8a8 
* Set poller threads as daemon threads so they dont block the main thread on exit.
@chanchiem chanchiem added the bug label Feb 28, 2019
@chanchiem
Copy link
Contributor Author

Minimal example to reproduce bug:

from aws_xray_sdk.core import xray_recorder

xray_recorder.configure(sampling=True)
xray_recorder.begin_segment("SomeSegment")
xray_recorder.end_segment()

exit() # Blocks forever

yogiraj07
yogiraj07 reviewed Mar 1, 2019
View reviewed changes
@chanchiem chanchiem merged commit 744360d into aws:master Mar 1, 2019
@chanchiem chanchiem deleted the thread_issue branch March 1, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogiraj07 yogiraj07 yogiraj07 approved these changes

@chrisradek chrisradek chrisradek approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanchiem @yogiraj07 @chrisradek