Skip to content

Max_trace_back = 0 returns full exception stack trace bug fix. (#120) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

chanchiem
Copy link
Contributor

@chanchiem chanchiem commented Jan 23, 2019

Check on max_trace_back in the recorder configuration now checks type as well as value >= 0
instead of pythonic variable check.

Furthermore, fixed an issue where if an empty list was used as the argument in the Throwable type initialization that it would cause the segment serialization to fail and therefore not send the segment to the daemon at all. This was causing issues when a segment was capturing a method while the max_trace_back configuration was set to 0 since it would pass in an empty list to the Throwable type initialization.

Added unit test to ensure zero value contains no stack. Tested on my local flask application as well to ensure no other issues would occur.

Issue #, if available:
#120

Description of changes:
Explicit int type checking for recorder.configuration of variable max_stack_trace, and ensuring that the value passed in is >= 0.

Testing:

  • Unit test to ensure that max_trace_back=0 configuration returns a segment with an exception stack containing an empty list.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check on max_trace_back in the recorder configuration now checks type as well as value >= 0
instead of pythonic variable check.

Added unit test to ensure zero value contains no stack. Tested on local application
@yogiraj07 yogiraj07 merged commit a9c866e into aws:master Jan 25, 2019
@chanchiem chanchiem deleted the max_stacktrace branch January 29, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants