Skip to content

Fixing Django 2.0 and TestClass tests errors #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Fixing Django 2.0 and TestClass tests errors #10

merged 1 commit into from
Dec 4, 2017

Conversation

levesquejf
Copy link
Contributor

By adding test = False in the TestServer Class, pytest ignores it so we don't get the warning message.

Django 2.0 is out and it causes errors with actual tests. I never used Django so I am not the best person to port the tests to 2.0 but with this change in tox.ini, Python 3 tests are not failing.

@haotianw465
Copy link
Contributor

I think this is fine. Since 2.0 is a new major version, we need to do some proper testing before claiming support for Django 2.0. One thing I want to confirm is that do you mean to prevent py2 test from failing?Django 2.0 drops py2 support but running with py3+ should be fine.

@levesquejf
Copy link
Contributor Author

The modules are not the same in Django 1.x and 2.0 so the tests on py3 are failing. It is also failing in py2 (unless you keep an old version in .tox as I did, my mistake). By removing .tox directory, without my changes, all versions are failing.

@haotianw465 haotianw465 merged commit fd09925 into aws:master Dec 4, 2017
@haotianw465 haotianw465 mentioned this pull request Sep 5, 2018
@adamchainz
Copy link
Contributor

The only reason Django bumped to 2.0 from 1.0 was dropping Python 3 support, the level of change is otherwise no more/less than other Django version changes (which aren't small however, reading the release notes is a good idea).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants