Skip to content

handle_content_missing RUNTIME_ERROR redundant error log #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melbaa opened this issue Nov 25, 2021 · 1 comment
Closed

handle_content_missing RUNTIME_ERROR redundant error log #316

melbaa opened this issue Nov 25, 2021 · 1 comment

Comments

@melbaa
Copy link

melbaa commented Nov 25, 2021

Hello,

I believe logging the error message at

log.error(MISSING_SEGMENT_MSG)
is redundant. The exception already carries the message.

My use case is to check if there's already a segment open via get_trace_entity(). I handle the exception and create a new segment if needed. I still end up with the error message from the SDK in my logs.

@melbaa melbaa changed the title handle_content_missing RUNTIME_ERROR reduntant error log handle_content_missing RUNTIME_ERROR redundant error log Nov 25, 2021
@melbaa
Copy link
Author

melbaa commented Dec 8, 2021

The fix made it into the 2.9.0 release, thanks!

@melbaa melbaa closed this as completed Dec 8, 2021
Hargrav3s pushed a commit to Gavant/aws-xray-sdk-python that referenced this issue Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant