Closed
Description
#283 makes Entity.to_dict
throw an exception in some cases. When to_dict
throws an exception, Entity.serialize
returns None
:
aws-xray-sdk-python/aws_xray_sdk/core/models/entity.py
Lines 264 to 265 in 7602447
Anyway, the None
is put into the message that is sent to the daemon, so the daemon gets {"format":"json","version":1}\nNone
, which is an invalid message.
aws-xray-sdk-python/aws_xray_sdk/core/emitters/udp_emitter.py
Lines 35 to 37 in 7602447
I don't think catching everything and returning None
in Entity.serialize
is a good idea. The exception should continue to be raised and the message send request should be aborted.
See also aws/aws-xray-daemon#120.
Metadata
Metadata
Assignees
Labels
No labels