Skip to content

patch_all() is unsafe #100

Open
Open
@IlyaSukhanov

Description

@IlyaSukhanov

There is a bit of ambiguity of patch_all() approach on aws-xray-sdk-python. Use thereof automatically enables new patchers regardless to how well they've been tested against real use cases (#48, #90). This in turn can can lead to a nasty surprise where deployment of lambda function will not work as it patches the calls.

Some ideas on making the situation better:

  1. Discourage use of patch_all()due to its unsafe nature.
  2. Do not include new patchers in patch_all() outside of major versions
  3. Split patch_all() into two functions patch_all() and patch_all_bleeding_edge() where new, and un-vetted patchers are first introduced into patch_all_bleeding_edge() and after they've been tested are then introduced to patch_all()

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions