Skip to content

Feat: update and apply S3 middleware #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 2, 2019
Merged

Feat: update and apply S3 middleware #478

merged 11 commits into from
Dec 2, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Nov 30, 2019

Updates and applies S3 middleware

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from AllanZhengYP November 30, 2019 00:31
@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Nov 30, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Nov 30, 2019 •
edited
Loading

Codecov Report

Merging #478 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           smithy-codegen    #478   +/-   ##
==============================================
  Coverage            94.6%   94.6%           
==============================================
  Files                  68      68           
  Lines                1280    1280           
  Branches              254     254           
==============================================
  Hits                 1211    1211           
  Misses                 69      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5442275...57cfe3a. Read the comment docs.

@kstich @AllanZhengYP
Add support for AWS JSON RPC protocols (aws#475)
2fa77b5 
This commit adds support for the AWS JSON RPC protocols,
building on top of the `HttpRpcProtocolGenerator` via the
`JsonRpcProtocolGenerator` abstract class. Specific
implementations are provided for `aws.json-1.0` and
`aws.json-1.1`.

Shared code between the JSON-based `ProtocolGenerator`
implementations has been moved to a utils class, specific
implementations have been updated.

Insubstantial tweaks and documentation updates have also
been made for clarity.
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase requested a review from AllanZhengYP December 2, 2019 16:38
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase merged commit 883d5ad into aws:smithy-codegen Dec 2, 2019
@srchase srchase deleted the s3-middleware branch December 2, 2019 17:32
AllanZhengYP pushed a commit that referenced this pull request Dec 2, 2019
@AllanZhengYP
Feat: update and apply S3 middleware (#478)
5a30b71 
* feat: migrate s3 middleware

* feat: apply validate-bucket-name plugin
AllanZhengYP pushed a commit to AllanZhengYP/aws-sdk-js-v3 that referenced this pull request Dec 3, 2019
@AllanZhengYP
Feat: update and apply S3 middleware (aws#478)
5b0a9c6 
* feat: migrate s3 middleware

* feat: apply validate-bucket-name plugin
@lock
Copy link

lock bot commented Dec 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srchase @aws-sdk-js-automation @codecov-io @AllanZhengYP @kstich