Skip to content

chore(scripts): include dependents when running tests in CI #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 27, 2022

Issue

Internal JS-3681

Description

Include dependents when running tests in CI

Testing

Verified that test in dependent middleware-sdk-s3 is run when types is updated.

# Make logger debug optional
$ git diff
diff --git a/packages/types/src/logger.ts b/packages/types/src/logger.ts
index 48db02d082..9e8a7a82bf 100644
--- a/packages/types/src/logger.ts
+++ b/packages/types/src/logger.ts
@@ -22,7 +22,7 @@ export interface LoggerOptions {
  */
 export interface Logger {
   trace?: (...content: any[]) => void;
-  debug: (...content: any[]) => void;
+  debug?: (...content: any[]) => void;
   info: (...content: any[]) => void;
   warn: (...content: any[]) => void;
   error: (...content: any[]) => void;
   
$ yarn test:ci
...
lerna notice cli v5.5.2
lerna notice filter changed since "origin/main"
lerna info Looking for changed packages since origin/main
lerna info Executing command in 106 packages: "yarn run test"
...
lerna info run Ran npm script 'test' in '@aws-sdk/middleware-sdk-s3' in 0.2s:
...

Additional context

This PR will be made ready once #4115 is merged. Ready!


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the remove-exclude-dependents-test-ci branch from 1cbc43a to 861d41c Compare October 28, 2022 17:31
@trivikr trivikr marked this pull request as ready for review October 28, 2022 17:35
@trivikr trivikr requested a review from a team as a code owner October 28, 2022 17:35
@trivikr trivikr merged commit ea98484 into aws:main Oct 28, 2022
@trivikr trivikr deleted the remove-exclude-dependents-test-ci branch October 28, 2022 22:28
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants