fix(types): make logger.trace an optional function #4110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Makes
trace
an optional function on logger, to preserve backward compatibility.The logger enforced functions debug, info, warn, error since GA. Adding trace should be optional to not break folks who're using logger without trace function.
Testing
Verified that unit test for package
middleware-sdk-s3
which mocks logger is successfulBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.