Skip to content

fix(types): make logger.trace an optional function #4110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 27, 2022

Issue

Description

Makes trace an optional function on logger, to preserve backward compatibility.
The logger enforced functions debug, info, warn, error since GA. Adding trace should be optional to not break folks who're using logger without trace function.

Testing

Verified that unit test for package middleware-sdk-s3 which mocks logger is successful

$ middleware-sdk-s3> yarn test
...
Test Suites: 4 passed, 4 total
Tests:       19 passed, 19 total
Snapshots:   0 total
Time:        4.587 s
Ran all test suites.
Done in 5.78s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review October 27, 2022 15:56
@trivikr trivikr requested a review from a team as a code owner October 27, 2022 15:56
@trivikr trivikr merged commit 7d95b34 into aws:main Oct 27, 2022
@trivikr trivikr deleted the logger-trace-optional branch October 27, 2022 15:59
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants