Skip to content

fix(client-eventbridge): remove middleware-sdk-eventbridge #4059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 20, 2022

Issue

Internal JS-3669

Description

Removes middleware-sdk-eventbridge, as the injection is done by endpoints 2.0 ruleset

Testing

Unit test is successful

$ client-eventbridge> yarn ts-mocha test/EventBridge.spec.ts                                         
yarn run v1.22.19
$ /local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/.bin/ts-mocha test/EventBridge.spec.ts


  EventBridge
    putEvents
      ✔ should use sign request with sigv4a with EventId presents


  1 passing (18ms)

Done in 0.84s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner October 20, 2022 06:18
@trivikr trivikr marked this pull request as draft October 20, 2022 15:06
@trivikr trivikr marked this pull request as ready for review October 20, 2022 15:08
@trivikr trivikr merged commit 7b1f599 into aws:main Oct 20, 2022
@trivikr trivikr deleted the test-eventbridge-fix branch October 20, 2022 15:09
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants