Skip to content

chore(middleware-retry): move non-config interfaces to types.ts #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 26, 2021

Issue

Refs: internal JS-2633

Description

move non-config interfaces to types.ts in middleware-retry.

This is similar to types.ts file in:

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from AllanZhengYP May 26, 2021 22:30
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@72611ca). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage        ?   59.08%           
=======================================
  Files           ?      490           
  Lines           ?    26204           
  Branches        ?     6224           
=======================================
  Hits            ?    15482           
  Misses          ?    10722           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72611ca...b0e6fec. Read the comment docs.

@trivikr trivikr merged commit c7371b6 into aws:main May 26, 2021
@trivikr trivikr deleted the move-retry-interface-types branch May 26, 2021 23:16
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants