fix(middleware-retry): make react-native-get-random-values optional #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyeotic
approved these changes
Mar 9, 2021
G-Rath
approved these changes
Mar 17, 2021
This was referenced Mar 18, 2021
Cruikshanks
added a commit
to DEFRA/sroc-charging-module-api
that referenced
this pull request
Mar 22, 2021
To support sending files to AWS S3 we recently added a [Send File To S3 service](#293). As part of that change we added `@aws-sdk/client-s3` as a dependency. Unfortunately, we got hit with 2 things at once. `client-s3` has a dependency on a middleware package that has a **peer** dependency on `react-native`. Also, npm v7 is out and that automatically installs peer dependencies, even when not really needed. Until aws/aws-sdk-js-v3#2108 is merged it looks like the workaround is to use the command [`npm install --only=production --legacy-peer-deps`](aws/aws-sdk-js-v3#2150 (comment)). This tells npm to use pre-v7 behaviours and not automatically install peer dependencies.
Cruikshanks
added a commit
to DEFRA/sroc-charging-module-api
that referenced
this pull request
Mar 23, 2021
To support sending files to AWS S3 we recently added a [Send File To S3 service](#293). As part of that change, we added `@aws-sdk/client-s3` as a dependency. Unfortunately, we got hit with 2 things at once. `client-s3` has a dependency on a middleware package that has a **peer** dependency on `react-native`. Also, npm v7 is out and that automatically installs peer dependencies, even when not really needed. Until aws/aws-sdk-js-v3#2108 is merged it looks like the workaround is to use the command [`npm install --legacy-peer-deps`](aws/aws-sdk-js-v3#2150 (comment)). This tells npm to use pre-v7 behaviours and not automatically install peer dependencies.
This was referenced Mar 26, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Admittedly, better than mine ;) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1536
Description
Mark react-native-get-random-values as optional peer dependency to prevent install on non React Native environments.
Testing
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.