Skip to content

test(client-iam): check for IAM.getUser instead of listUsers #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 20, 2020

Issue #, if available:
Refs: aws/aws-sdk-js#3542

Description of changes:
Checks for getUser instead of listUsers in IAM integration tests.

The test fails if there are more than 100 users, as it parses users from
first page of results. This code change explicitly requests for the created user
to ensure it doesn't return pages of results.

$ yarn test:integration-legacy --tags @iam
yarn run v1.22.5
$ cucumber-js --fail-fast --tags @iam
...................

3 scenarios (3 passed)
13 steps (13 passed)
0m01.277s
Done in 3.93s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The test fails if there are more than 100 users, as it parses users from
first page of results. This code change explicitly requests for the created user
to ensure it doesn't return pages of results.
@trivikr trivikr merged commit 4e02fbd into aws:master Dec 1, 2020
@trivikr trivikr deleted the integ-test-iam-user branch December 1, 2020 17:32
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants