Skip to content

chore(tsconfig): move common values to root tsconfig.es.json #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 14, 2020

Issue #, if available:
Refs: #1563
This PR would be rebased and set "ready to review" once #1572 is merged. It's ready for review.

Description of changes:
move common values to root tsconfig.es.json

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the move-common-tsconfig-root-es branch from 8315359 to bee6a43 Compare October 15, 2020 16:50
@trivikr trivikr marked this pull request as ready for review October 15, 2020 16:58
@codecov-io
Copy link

Codecov Report

Merging #1574 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1574   +/-   ##
=======================================
  Coverage   79.92%   79.92%           
=======================================
  Files         313      313           
  Lines       11839    11839           
  Branches     2504     2504           
=======================================
  Hits         9462     9462           
  Misses       2377     2377           
Impacted Files Coverage Δ
packages/util-create-request/src/index.ts 100.00% <ø> (ø)
packages/util-create-request/src/foo.fixture.ts 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d75c5...bee6a43. Read the comment docs.

@trivikr trivikr requested a review from alexforsyth October 15, 2020 17:22
@trivikr trivikr merged commit 658876d into aws:master Oct 19, 2020
@trivikr trivikr deleted the move-common-tsconfig-root-es branch October 19, 2020 19:20
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants