fix: serializer throws when hostname prefix is applied #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1475 +/- ##
=======================================
Coverage 79.80% 79.81%
=======================================
Files 298 298
Lines 11502 11507 +5
Branches 2475 2477 +2
=======================================
+ Hits 9179 9184 +5
Misses 2323 2323
Continue to review full report at Codecov.
|
AllanZhengYP
force-pushed
the
fix-host-prefix
branch
from
8c9d540 to
d03b625
Compare
trivikr
approved these changes
Aug 28, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: smithy-lang/smithy-typescript#206
Description of changes:
Currently, SDK will throw when serializing
client-iotsitewiseandclient-servicediscoveryclients requests, because of a bug in serializer. This change fixes the issue.This change also update the regex used to validate the host name in
isValidHostname.ts. The regex was originally added in #774 but only validates host labels instead of the full host name. For example,s3.amazonaws.comwas incorrectly detected as an invalid hostname with original regex.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.