Skip to content

test(middleware-sdk-transcribe-streaming): extensive tests for signer.ts #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 8, 2020

Issue #, if available:
follow-up to #1336

Description of changes:
extensive tests for signer.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1343 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
+ Coverage   77.67%   77.70%   +0.02%     
==========================================
  Files         286      287       +1     
  Lines       11955    11970      +15     
  Branches     2623     2626       +3     
==========================================
+ Hits         9286     9301      +15     
  Misses       2669     2669              
Impacted Files Coverage Δ
.../middleware-sdk-transcribe-streaming/src/signer.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ca2a4...8dd2246. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The test looks much better now!

@trivikr trivikr merged commit 45240e6 into aws:master Jul 10, 2020
@trivikr trivikr deleted the extensive-testing-signer branch July 10, 2020 17:33
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants