Skip to content

test: enable termination protection in CloudFormation integ test #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 20, 2020

Issue #, if available:
Similar to aws/aws-sdk-js#3252

Description of changes:
enable termination protection in CloudFormation integ test

Verified that integration tests are successful:

$ AWS_PROFILE=<profile> yarn test:integration --tags @cloudformation
yarn run v1.22.4
$ cucumber-js --fail-fast --tags @cloudformation
.........

2 scenarios (2 passed)
5 steps (5 passed)
0m00.149s
Done in 2.13s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: f7c730a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 1074b06 into aws:master May 26, 2020
@trivikr trivikr deleted the integ-test-enable-termination-protection branch May 26, 2020 23:28
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants