Skip to content

chore: define headers while declaring #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 2, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#175

Description of changes:
Define headers while declaring

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: b871590
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr force-pushed the define-headers-declaration branch from b871590 to 791dcfa Compare May 4, 2020 18:15
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 791dcfa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr force-pushed the define-headers-declaration branch from 791dcfa to 19035b2 Compare May 8, 2020 03:02
@codecov-io
Copy link

Codecov Report

Merging #1134 into master will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
- Coverage   73.85%   73.42%   -0.44%     
==========================================
  Files         284      284              
  Lines       13175    12924     -251     
  Branches     3106     3108       +2     
==========================================
- Hits         9731     9490     -241     
+ Misses       3444     3434      -10     
Impacted Files Coverage Δ
protocol_tests/aws-ec2/protocols/Aws_ec2.ts 63.99% <ø> (-0.95%) ⬇️
protocol_tests/aws-json/protocols/Aws_json1_1.ts 68.80% <ø> (-0.52%) ⬇️
protocol_tests/aws-query/protocols/Aws_query.ts 68.58% <ø> (-0.96%) ⬇️
...ol_tests/aws-restjson/protocols/Aws_restJson1_1.ts 64.40% <ø> (-1.44%) ⬇️
...rotocol_tests/aws-restxml/protocols/Aws_restXml.ts 67.65% <ø> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcfa99c...19035b2. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 19035b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr marked this pull request as ready for review May 11, 2020 18:51
@trivikr trivikr merged commit 1bd0678 into aws:master May 11, 2020
@trivikr trivikr deleted the define-headers-declaration branch May 11, 2020 18:53
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants