Skip to content

chore: fast fail integration tests #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 22, 2020

Issue #, if available:
N/A

Description of changes:

  • fast failing integration tests helps with debugging
  • verified that test fails and process exits:
yarn test:integration
yarn run v1.22.4
$ cucumber-js --fail-fast
.............F-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Failures:

1) Scenario: Making a request # features/apigateway/apigateway.feature:7
   ✔ Before # features/apigateway/step_definitions/apigateway.js:4
   ✔ Before # features/extra/hooks.js:22
   ✔ Given I run the "getRestApis" operation # features/extra/hooks.js:76
   ✔ Then the request should be successful # features/extra/hooks.js:88
   ✖ And the value at "items" should be a list # features/extra/hooks.js:93
       AssertionError [ERR_ASSERTION]
           + expected - actual

           -false
           +true
       
           at Object.<anonymous> (/local/home/trivikr/workspace/aws-sdk-js-v3/features/extra/hooks.js:95:15)

153 scenarios (1 failed, 150 skipped, 2 passed)
534 steps (1 failed, 526 skipped, 7 passed)
0m00.203s
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit fde80bf into aws:master Apr 22, 2020
@trivikr trivikr deleted the integ-test-fail-first branch April 22, 2020 19:20
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: d5d2046
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants