The comments are not removed from transpiled `*.js` files

[trivikr]

Describe the bug

The comments are not removed from transpiled *.js files
Refs: #2817

Your environment

SDK version number

@aws-sdk/client-sts@3.36.0

Is the issue in the browser/Node.js/ReactNative?

Node.js

Details of the browser/Node.js/ReactNative version

v14.18.0

Steps to reproduce

• Create a fresh workspace.
• Install @aws-sdk/client-sts@3.36.0
• tail node_modules/@aws-sdk/client-sts/dist-cjs/STSClient.js

Observed behavior

The comments are present in transpiled *.js files.

$ tail node_modules/@aws-sdk/client-sts/dist-cjs/STSClient.js
    /**
     * Destroy underlying resources, like sockets. It's usually not necessary to do this.
     * However in Node.js, it's best to explicitly shut down the client's agent when it is no longer needed.
     * Otherwise, sockets might stay open for quite a long time before the server terminates them.
     */
    destroy() {
        super.destroy();
    }
}
exports.STSClient = STSClient;

Expected behavior

The comments should be removed from transpiled *.js files.

$ tail node_modules/@aws-sdk/client-sts/dist-cjs/STSClient.js
        this.middlewareStack.use(middleware_content_length_1.getContentLengthPlugin(this.config));
        this.middlewareStack.use(middleware_host_header_1.getHostHeaderPlugin(this.config));
        this.middlewareStack.use(middleware_logger_1.getLoggerPlugin(this.config));
        this.middlewareStack.use(middleware_user_agent_1.getUserAgentPlugin(this.config));
    }
    destroy() {
        super.destroy();
    }
}
exports.STSClient = STSClient;

[trivikr]

This happens as tsconfig.types.json overwrites dist-cjs folder adding comments

aws-sdk-js-v3/clients/client-sts/tsconfig.types.json

Lines 1 to 9 in 6dd0af8

	{
	"extends": "./tsconfig",
	"compilerOptions": {
	"removeComments": false,
	"declaration": true,
	"declarationDir": "dist-types"
	},
	"exclude": ["test/**/*", "dist-types/**/*"]
	}

The comments are not present in dist-es

$ tail node_modules/@aws-sdk/client-sts/dist-es/STSClient.js
        _this.middlewareStack.use(getLoggerPlugin(_this.config));
        _this.middlewareStack.use(getUserAgentPlugin(_this.config));
        return _this;
    }
    STSClient.prototype.destroy = function () {
        _super.prototype.destroy.call(this);
    };
    return STSClient;
}(__Client));
export { STSClient };

[trivikr]

This issue happens as emitDeclarationOnly is not added in tsconfig.types.json in clients.

It's present in root tsconfig.types.json

aws-sdk-js-v3/tsconfig.types.json

Line 5 in 6dd0af8

"emitDeclarationOnly": true,

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.