Replace unused maxRetries with maxAttempts

[trivikr]

Describe the bug

The maxRetries configuration was added in remote credentials provider back in Jun 15, 2017 in
d2b251e

The configuration maxRetries was changed to maxAttempts in middleware-retry to be compliant with other SDKs and retry strategy #1244

This change wasn't done in credential providers though.

Proposed fix

• Add new configuration maxAttempts in RemoteProviderConfig, so that it reuses the value from retry while fetching credentials.
• Instead of deleting existing maxRetries, call it deprecated in favor of maxAttempts.

Additional context

The bug was noticed while debugging retry strategy options for RemoteProviderConfig requested in #2706

[andre-araujo]

smithy-lang/smithy-typescript#1346

[trivikr]

The internal utility providerConfigFromInit is called from:

• fromContainerMetadata https://github.com/smithy-lang/smithy-typescript/blob/86862eab5e8b26520a2a3e9914d24a9ab5a98270/packages/credential-provider-imds/src/fromContainerMetadata.ts#L31
• getInstanceMetadataProvider https://github.com/smithy-lang/smithy-typescript/blob/86862eab5e8b26520a2a3e9914d24a9ab5a98270/packages/credential-provider-imds/src/fromInstanceMetadata.ts#L37

These utilities are further called from other providers or re-exported, like:

• remoteProvider

  aws-sdk-js-v3/packages/credential-provider-node/src/remoteProvider.ts

  Line 24 in ac98acc

  return chain(fromHttp(init), fromContainerMetadata(init));

• resolveCredentialSource

  aws-sdk-js-v3/packages/credential-provider-ini/src/resolveCredentialSource.ts

  Lines 24 to 29 in ac98acc

  	return chain(fromHttp(options ?? {}), fromContainerMetadata(options));
  	},
  	Ec2InstanceMetadata: async (options?: CredentialProviderOptions) => {
  	logger?.debug("@aws-sdk/credential-provider-ini - credential_source is Ec2InstanceMetadata");
  	const { fromInstanceMetadata } = await import("@smithy/credential-provider-imds");
  	return fromInstanceMetadata(options);

• fromInstanceMetadata:

  aws-sdk-js-v3/packages/credential-providers/src/fromInstanceMetadata.ts

  Line 31 in ac98acc

  return _fromInstanceMetadata(init);

• fromContainerMetadata

  aws-sdk-js-v3/packages/credential-providers/src/fromContainerMetadata.ts

  Line 31 in ac98acc

  return _fromContainerMetadata(init);

The ask for this issue is to remove maxRetries configuration from credential providers, as part of standardization, since we use maxAttempts in clients. It requires three things to be done:

• Deprecate maxRetries in init used by fromContainerMetadata and getInstanceMetadataProvider in favor of maxAttempts
• Add JSDoc that maxAttempts is recommended, and it's value if one more than maxRetries
• In resolving the values, like in providerConfigFromInit favor value in maxAttempts over that in maxRetries, and use it for any attempts made in internal code.