fix: manual configuration and code updates for eslint

Author: alexforsyth

.eslintrc.js

@@ -5,10 +5,18 @@ module.exports = {
     sourceType: "module" // Allows for the use of imports
   },
   extends: [
-    "plugin:@typescript-eslint/recommended" // Uses the recommended rules from the @typescript-eslint/eslint-plugin
+    // Uses the recommended rules from the @typescript-eslint/eslint-plugin
+    "plugin:@typescript-eslint/recommended"
   ],
+  plugins: ["@typescript-eslint", "simple-import-sort"],
   rules: {
-    // Place to specify ESLint rules. Can be used to overwrite rules specified from the extended configs
-    // e.g. "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/ban-types": "off",
+    "@typescript-eslint/ban-ts-comment": "off",
+    "@typescript-eslint/no-var-requires": "off",
+    "@typescript-eslint/no-empty-function": "off",
+    "@typescript-eslint/no-empty-interface": "off",
+    "@typescript-eslint/no-namespace": "warn",
+    "prefer-rest-params": "off",
+    "simple-import-sort/sort": "error"
   }
 };

.prettierrc

@@ -2,5 +2,7 @@
   "$schema": "http://json.schemastore.org/prettierrc",
   "arrowParens": "avoid",
   "endOfLine": "auto",
+  "semi": true,
+  "printWidth": 120,
   "trailingComma": "none"
 }

.prettierrc.js

@@ -52,6 +52,7 @@
     "eslint": "^7.4.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-plugin-prettier": "^3.1.4",
+    "eslint-plugin-simple-import-sort": "^5.0.3",
     "fs-extra": "^9.0.0",
     "generate-changelog": "^1.7.1",
     "husky": "^4.2.3",

package.json

@@ -1,10 +1,5 @@
 import { EventStreamMarshaller as EventMarshaller } from "@aws-sdk/eventstream-marshaller";
-import {
-  Encoder,
-  Decoder,
-  Message,
-  EventStreamMarshaller as IEventStreamMarshaller
-} from "@aws-sdk/types";
+import { Encoder, Decoder, Message, EventStreamMarshaller as IEventStreamMarshaller } from "@aws-sdk/types";
 import { getChunkedStream } from "./getChunkedStream";
 import { getUnmarshalledStream } from "./getUnmarshalledStream";
 
@@ -36,14 +31,10 @@ export class EventStreamMarshaller {
     return unmarshalledStream;
   }
 
-  serialize<T>(
-    input: AsyncIterable<T>,
-    serializer: (event: T) => Message
-  ): AsyncIterable<Uint8Array> {
-    const self = this;
+  serialize<T>(input: AsyncIterable<T>, serializer: (event: T) => Message): AsyncIterable<Uint8Array> {
     const serializedIterator = async function* () {
       for await (const chunk of input) {
-        const payloadBuf = self.eventMarshaller.marshall(serializer(chunk));
+        const payloadBuf = this.eventMarshaller.marshall(serializer(chunk));
         yield payloadBuf;
       }
       // Ending frame

packages/eventstream-serde-universal/src/EventStreamMarshaller.ts

@@ -2,7 +2,8 @@ import { HttpRequest } from "@aws-sdk/types";
 import { buildQueryString } from "@aws-sdk/querystring-builder";
 
 export function formatUrl(request: HttpRequest): string {
-  let { protocol, path, hostname, port, query } = request;
+  const { port, query } = request;
+  let { protocol, path, hostname } = request;
   if (protocol && protocol.substr(-1) !== ":") {
     protocol += ":";
   }

packages/util-format-url/src/index.ts

@@ -4576,6 +4576,11 @@ eslint-plugin-prettier@^3.1.4:
   dependencies:
     prettier-linter-helpers "^1.0.0"
 
+eslint-plugin-simple-import-sort@^5.0.3:
+  version "5.0.3"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-5.0.3.tgz#9ae258ddada6efffc55e47a134afbd279eb31fc6"
+  integrity sha512-1rf3AWiHeWNCQdAq0iXNnlccnH1UDnelGgrPbjBBHE8d2hXVtOudcmy0vTF4hri3iJ0MKz8jBhmH6lJ0ZWZLHQ==
+
 eslint-scope@^4.0.3:
   version "4.0.3"
   resolved "https://registry.yarnpkg.com/eslint-scope/-/eslint-scope-4.0.3.tgz#ca03833310f6889a3264781aa82e63eb9cfe7848"