fix: auto lint fixes

Author: alexforsyth

packages/chunked-stream-reader-node/src/index.ts

@@ -2,7 +2,7 @@ import { Readable } from "stream";
 export function streamReader(
   stream: Readable,
   onChunk: (chunk: Uint8Array) => void,
-  chunkSize: number = 1048576 // 1 MiB
+  chunkSize = 1048576 // 1 MiB
 ): Promise<void> {
   return new Promise((resolve, reject) => {
     let temporaryBuffer: Uint8Array | undefined;

packages/chunked-stream-reader-node/src/readable.fixture.ts

@@ -7,7 +7,7 @@ export interface ReadFromBuffersOptions extends ReadableOptions {
 
 export class ReadFromBuffers extends Readable {
   private buffersToRead: Buffer[];
-  private numBuffersRead: number = 0;
+  private numBuffersRead = 0;
 
   private errorAfter: number;
   constructor(options: ReadFromBuffersOptions) {

packages/config-resolver/src/RegionConfig.ts

@@ -15,7 +15,7 @@ export interface RegionResolvedConfig {
 export function resolveRegionConfig<T>(
   input: T & RegionInputConfig & PreviouslyResolved
 ): T & RegionResolvedConfig {
-  let region = input.region || input.regionDefaultProvider(input as any);
+  const region = input.region || input.regionDefaultProvider(input as any);
   return {
     ...input,
     region: normalizeRegion(region)

packages/credential-provider-imds/src/fromContainerMetadata.spec.ts

@@ -91,7 +91,7 @@ describe("fromContainerMetadata", () => {
     });
 
     it("should retry responses that receive invalid response values", async () => {
-      for (let key of Object.keys(creds)) {
+      for (const key of Object.keys(creds)) {
         const invalidCreds: any = { ...creds };
         delete invalidCreds[key];
         mockHttpGet.mockReturnValueOnce(

packages/credential-provider-ini/src/index.spec.ts

@@ -18,7 +18,7 @@ jest.mock("fs", () => {
   }
 
   const fs: FsModule = <FsModule>jest.genMockFromModule("fs");
-  let matchers = new Map<string, string>();
+  const matchers = new Map<string, string>();
 
   function readFile(
     path: string,
@@ -721,7 +721,7 @@ source_profile = default
         { creds: FOO_CREDS, arn: roleArnFor("foo") }
       ];
 
-      for (let { creds, arn } of expectedCalls) {
+      for (const { creds, arn } of expectedCalls) {
         const call = <any>roleAssumer.mock.calls.shift();
         expect(call[0]).toEqual(creds);
         expect(call[1].RoleArn).toEqual(arn);

packages/credential-provider-process/src/index.spec.ts

@@ -17,7 +17,7 @@ jest.mock("fs", () => {
   }
 
   const fs: FsModule = <FsModule>jest.genMockFromModule("fs");
-  let matchers = new Map<string, string>();
+  const matchers = new Map<string, string>();
 
   function readFile(
     path: string,
@@ -72,7 +72,7 @@ jest.mock("child_process", () => {
   const child_process = <ChildProcessModule>(
     jest.genMockFromModule("child_process")
   );
-  let matchers = new Map<string, string>();
+  const matchers = new Map<string, string>();
 
   function exec(
     command: string,

packages/eventstream-handler-node/src/EventSigningStream.spec.ts

@@ -4,7 +4,7 @@ import { toUtf8, fromUtf8 } from "@aws-sdk/util-utf8-node";
 import { Message, MessageHeaders } from "@aws-sdk/types";
 
 describe("EventSigningStream", () => {
-  let originalDate = Date;
+  const originalDate = Date;
   afterEach(() => {
     Date = originalDate;
   });

packages/eventstream-handler-node/src/EventSigningStream.ts

@@ -44,7 +44,7 @@ export class EventSigningStream extends Transform {
       const dateHeader: MessageHeaders = {
         ":date": { type: "timestamp", value: now }
       };
-      let signature = await this.eventSigner.sign(
+      const signature = await this.eventSigner.sign(
         {
           payload: chunk,
           headers: this.eventMarshaller.formatHeaders(dateHeader)

packages/eventstream-marshaller/src/Int64.ts

@@ -1,7 +1,7 @@
 import { toHex } from "@aws-sdk/util-hex-encoding";
 import { Int64 as IInt64 } from "@aws-sdk/types";
 
-export interface Int64 extends IInt64 {}
+export type Int64 = IInt64;
 
 /**
  * A lossless representation of a signed, 64-bit integer. Instances of this

packages/eventstream-serde-browser/src/EventStreamMarshaller.ts

@@ -8,7 +8,7 @@ import {
 } from "@aws-sdk/types";
 import { readableStreamtoIterable, iterableToReadableStream } from "./utils";
 
-export interface EventStreamMarshaller extends IEventStreamMarshaller {}
+export type EventStreamMarshaller = IEventStreamMarshaller;
 
 export interface EventStreamMarshallerOptions {
   utf8Encoder: Encoder;

packages/eventstream-serde-node/src/EventStreamMarshaller.ts

@@ -9,7 +9,7 @@ import {
 import { Readable } from "stream";
 import { readabletoIterable } from "./utils";
 
-export interface EventStreamMarshaller extends IEventStreamMarshaller {}
+export type EventStreamMarshaller = IEventStreamMarshaller;
 
 export interface EventStreamMarshallerOptions {
   utf8Encoder: Encoder;

packages/eventstream-serde-universal/src/EventStreamMarshaller.ts

@@ -8,7 +8,7 @@ import {
 import { getChunkedStream } from "./getChunkedStream";
 import { getUnmarshalledStream } from "./getUnmarshalledStream";
 
-export interface EventStreamMarshaller extends IEventStreamMarshaller {}
+export type EventStreamMarshaller = IEventStreamMarshaller;
 
 export interface EventStreamMarshallerOptions {
   utf8Encoder: Encoder;

packages/fetch-http-handler/src/fetch-http-handler.browser.spec.ts

@@ -3,7 +3,7 @@ import { FetchHttpHandler } from "./fetch-http-handler";
 describe(FetchHttpHandler.name, () => {
   it("calls request without mode included in requestOptions", done => {
     const fetchHttpHandler = new FetchHttpHandler();
-    let spy = spyOn(window, "Request");
+    const spy = spyOn(window, "Request");
     fetchHttpHandler.handle({} as any, {});
     expect(spy.calls.argsFor(0)[1].mode).toEqual(undefined);
     done();

packages/fetch-http-handler/src/fetch-http-handler.spec.ts

@@ -47,14 +47,14 @@ describe.skip(FetchHttpHandler.name, () => {
     (global as any).fetch = mockFetch;
     const fetchHttpHandler = new FetchHttpHandler();
 
-    let response = await fetchHttpHandler.handle({} as any, {});
+    const response = await fetchHttpHandler.handle({} as any, {});
 
     expect(mockFetch.mock.calls.length).toBe(1);
     expect(await blobToText(response.response.body)).toBe("FOO");
   });
 
   it("properly constructs url", async () => {
-    let mockResponse = {
+    const mockResponse = {
       headers: {
         entries: jest.fn().mockReturnValue([
           ["foo", "bar"],
@@ -67,7 +67,7 @@ describe.skip(FetchHttpHandler.name, () => {
 
     (global as any).fetch = mockFetch;
 
-    let httpRequest = new HttpRequest({
+    const httpRequest = new HttpRequest({
       headers: {},
       hostname: "foo.amazonaws.com",
       method: "GET",
@@ -77,15 +77,15 @@ describe.skip(FetchHttpHandler.name, () => {
     });
     const fetchHttpHandler = new FetchHttpHandler();
 
-    let response = await fetchHttpHandler.handle(httpRequest, {});
+    const response = await fetchHttpHandler.handle(httpRequest, {});
 
     expect(mockFetch.mock.calls.length).toBe(1);
-    let requestCall = mockRequest.mock.calls[0];
+    const requestCall = mockRequest.mock.calls[0];
     expect(requestCall[0]).toBe("https://foo.amazonaws.com:443/test/?bar=baz");
   });
 
   it("will not make request if already aborted", async () => {
-    let mockResponse = {
+    const mockResponse = {
       headers: {
         entries: jest.fn().mockReturnValue([
           ["foo", "bar"],
@@ -111,7 +111,7 @@ describe.skip(FetchHttpHandler.name, () => {
   });
 
   it("will pass abortSignal to fetch if supported", async () => {
-    let mockResponse = {
+    const mockResponse = {
       headers: {
         entries: jest.fn().mockReturnValue([
           ["foo", "bar"],
@@ -125,7 +125,7 @@ describe.skip(FetchHttpHandler.name, () => {
     (global as any).AbortController = jest.fn();
     const fetchHttpHandler = new FetchHttpHandler();
 
-    let response = await fetchHttpHandler.handle({} as any, {
+    const response = await fetchHttpHandler.handle({} as any, {
       abortSignal: {
         aborted: false
       }
@@ -136,7 +136,7 @@ describe.skip(FetchHttpHandler.name, () => {
   });
 
   it("will pass timeout to request timeout", async () => {
-    let mockResponse = {
+    const mockResponse = {
       headers: {
         entries: jest.fn().mockReturnValue([
           ["foo", "bar"],
@@ -153,7 +153,7 @@ describe.skip(FetchHttpHandler.name, () => {
       requestTimeout: 500
     });
 
-    let response = await fetchHttpHandler.handle({} as any, {});
+    const response = await fetchHttpHandler.handle({} as any, {});
 
     expect(mockFetch.mock.calls.length).toBe(1);
     expect(timeoutSpy.mock.calls[0][0]).toBe(500);

packages/fetch-http-handler/src/fetch-http-handler.ts

@@ -3,7 +3,7 @@ import { HttpHandler, HttpRequest, HttpResponse } from "@aws-sdk/protocol-http";
 import { requestTimeout } from "./request-timeout";
 import { buildQueryString } from "@aws-sdk/querystring-builder";
 
-declare var AbortController: any;
+declare let AbortController: any;
 
 /**
  * Represents the http options that can be passed to a browser http client.
@@ -67,7 +67,7 @@ export class FetchHttpHandler implements HttpHandler {
         const fetchHeaders: any = response.headers;
         const transformedHeaders: HeaderBag = {};
 
-        for (let pair of <Array<string[]>>fetchHeaders.entries()) {
+        for (const pair of <Array<string[]>>fetchHeaders.entries()) {
           transformedHeaders[pair[0]] = pair[1];
         }
 

packages/fetch-http-handler/src/request-timeout.ts

@@ -1,4 +1,4 @@
-export function requestTimeout(timeoutInMs: number = 0): Promise<never> {
+export function requestTimeout(timeoutInMs = 0): Promise<never> {
   return new Promise((resolve, reject) => {
     if (timeoutInMs) {
       setTimeout(() => {

packages/is-array-buffer/src/index.spec.ts

@@ -19,7 +19,7 @@ describe("isArrayBuffer", () => {
   });
 
   it("should return false for scalar values", () => {
-    for (let scalar of ["string", 123.234, true, null, void 0]) {
+    for (const scalar of ["string", 123.234, true, null, void 0]) {
       expect(isArrayBuffer(scalar)).toBe(false);
     }
   });

packages/md5-js/src/constants.ts

@@ -1,12 +1,12 @@
 /**
  * @internal
  */
-export const BLOCK_SIZE: number = 64;
+export const BLOCK_SIZE = 64;
 
 /**
  * @internal
  */
-export const DIGEST_LENGTH: number = 16;
+export const DIGEST_LENGTH = 16;
 
 /**
  * @internal

packages/md5-js/src/index.ts

@@ -5,9 +5,9 @@ import { fromUtf8 } from "@aws-sdk/util-utf8-browser";
 export class Md5 implements Hash {
   private state = Uint32Array.from(INIT);
   private buffer: DataView = new DataView(new ArrayBuffer(BLOCK_SIZE));
-  private bufferLength: number = 0;
-  private bytesHashed: number = 0;
-  private finished: boolean = false;
+  private bufferLength = 0;
+  private bytesHashed = 0;
+  private finished = false;
 
   update(sourceData: SourceData): void {
     if (isEmptyData(sourceData)) {

packages/middleware-bucket-endpoint/src/bucketEndpointMiddleware.ts

@@ -22,7 +22,7 @@ export function bucketEndpointMiddleware(
   ): Promise<BuildHandlerOutput<Output>> => {
     const { Bucket: bucketName } = args.input;
     let replaceBucketInPath = options.bucketEndpoint;
-    let request = args.request;
+    const request = args.request;
     if (HttpRequest.isInstance(request)) {
       if (options.bucketEndpoint) {
         request.hostname = bucketName;

packages/middleware-content-length/src/index.ts

@@ -20,7 +20,7 @@ export function contentLengthMiddleware(
   ): BuildHandler<any, Output> => async (
     args: BuildHandlerArguments<any>
   ): Promise<BuildHandlerOutput<Output>> => {
-    let request = args.request;
+    const request = args.request;
     if (HttpRequest.isInstance(request)) {
       const { body, headers } = request;
       if (

packages/middleware-expect-continue/src/index.ts

@@ -21,7 +21,7 @@ export function addExpectContinueMiddleware(
   ): BuildHandler<any, Output> => async (
     args: BuildHandlerArguments<any>
   ): Promise<BuildHandlerOutput<Output>> => {
-    let { request } = args;
+    const { request } = args;
     if (
       HttpRequest.isInstance(request) &&
       request.body &&

packages/middleware-sdk-api-gateway/src/index.ts

@@ -15,7 +15,7 @@ export function acceptHeaderMiddleware(): BuildMiddleware<any, any> {
   ): BuildHandler<any, Output> => async (
     args: BuildHandlerArguments<any>
   ): Promise<BuildHandlerOutput<Output>> => {
-    let { request } = args;
+    const { request } = args;
     if (HttpRequest.isInstance(request)) {
       request.headers = {
         ...request.headers,

packages/middleware-sdk-glacier/src/add-checksum-headers.ts

@@ -17,7 +17,7 @@ export function addChecksumHeadersMiddleware(
   ): BuildHandler<any, Output> => async (
     args: BuildHandlerArguments<any>
   ): Promise<BuildHandlerOutput<Output>> => {
-    let request = args.request;
+    const request = args.request;
     if (HttpRequest.isInstance(request)) {
       let headers = request.headers;
       const body = request.body;

packages/middleware-sdk-glacier/src/add-glacier-api-version.ts

@@ -17,7 +17,7 @@ export function addGlacierApiVersionMiddleware(
   ): BuildHandler<any, Output> => async (
     args: BuildHandlerArguments<any>
   ): Promise<BuildHandlerOutput<Output>> => {
-    let request = args.request;
+    const request = args.request;
     if (HttpRequest.isInstance(request)) {
       request.headers["x-amz-glacier-version"] = options.apiVersion;
     }

packages/middleware-sdk-s3-control/src/prepend-account-id.ts

@@ -16,7 +16,7 @@ export function prependAccountIdMiddleware(): BuildMiddleware<any, any> {
   ): BuildHandler<any, Output> => async (
     args: BuildHandlerArguments<any>
   ): Promise<BuildHandlerOutput<Output>> => {
-    let { request } = args;
+    const { request } = args;
     const { input } = args;
     const accountId = input.AccountId;
     if (typeof accountId !== "string") {

packages/middleware-sdk-sqs/src/receive-message.ts

@@ -30,7 +30,7 @@ export function receiveMessageMiddleware(
   ): Promise<InitializeHandlerOutput<Output>> => {
     const resp = await next({ ...args });
     const output = (resp.output as unknown) as ReceiveMessageResult;
-    let messageIds = [];
+    const messageIds = [];
     if (output.Messages !== undefined) {
       for (const message of output.Messages) {
         const md5 = message.MD5OfBody;

packages/middleware-sdk-sqs/src/send-message-batch.ts

@@ -30,8 +30,8 @@ export function sendMessageBatchMiddleware(
   ): Promise<InitializeHandlerOutput<Output>> => {
     const resp = await next({ ...args });
     const output = (resp.output as unknown) as SendMessageBatchResult;
-    let messageIds = [];
-    let entries: { [index: string]: SendMessageBatchResultEntry } = {};
+    const messageIds = [];
+    const entries: { [index: string]: SendMessageBatchResultEntry } = {};
     if (output.Successful !== undefined) {
       for (const entry of output.Successful) {
         if (entry.Id !== undefined) {

packages/middleware-signing/src/configurations.ts

@@ -51,7 +51,7 @@ export interface AwsAuthResolvedConfig {
 export function resolveAwsAuthConfig<T>(
   input: T & AwsAuthInputConfig & PreviouslyResolved
 ): T & AwsAuthResolvedConfig {
-  let credentials =
+  const credentials =
     input.credentials || input.credentialDefaultProvider(input as any);
   const normalizedCreds = normalizeProvider(credentials);
   const {

packages/middleware-stack/src/MiddlewareStack.spec.ts

@@ -192,7 +192,7 @@ describe("MiddlewareStack", () => {
 
     const secondStack = stack.clone();
 
-    let inner = jest.fn(({ input }: DeserializeHandlerArguments<input>) => {
+    const inner = jest.fn(({ input }: DeserializeHandlerArguments<input>) => {
       expect(input).toEqual(["first", "second"]);
       return Promise.resolve({ response: {} });
     });
@@ -232,7 +232,7 @@ describe("MiddlewareStack", () => {
       { step: "build", relation: "after", toMiddleware: "second" }
     );
 
-    let inner = jest.fn(({ input }: DeserializeHandlerArguments<input>) => {
+    const inner = jest.fn(({ input }: DeserializeHandlerArguments<input>) => {
       expect(input).toEqual(["first", "second", "third", "fourth"]);
       return Promise.resolve({ response: {} });
     });