Turning off trailing checksums for SSE #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Dec 5, 2018
|
|
||
| // S3 doesn't support trailing checksums for KMS encrypted objects | ||
| if (headers.getOrDefault(SERVER_SIDE_ENCRYPTION_HEADER, new ArrayList<>()).contains(AWS_KMS.toString())) { | ||
| return false; |
There was a problem hiding this comment.
Should we move the checks to an util method so that it can be used in both sync and async?
There was a problem hiding this comment.
Updated. Not sure that I love the name. Feel free to give ideas.
| .bucket(BUCKET) | ||
| .build(); | ||
|
|
||
| s3.getObject(getObjectRequest); |
There was a problem hiding this comment.
Nit, can we close the response streams afterwards?
| .bucket(BUCKET) | ||
| .build(); | ||
|
|
||
| s3Async.getObject(getObjectRequest, AsyncResponseTransformer.toBytes()); |
There was a problem hiding this comment.
.join()? same as other tests.
dagnir
reviewed
Dec 6, 2018
| } | ||
|
|
||
| // S3 doesn't support trailing checksums for KMS encrypted objects | ||
| if (headers.getOrDefault(SERVER_SIDE_ENCRYPTION_HEADER, new ArrayList<>()).contains(AWS_KMS.toString())) { |
There was a problem hiding this comment.
minor: replace new with Collections.emptyList()
spfink
force-pushed
the
finks/checksum-sse
branch
from
3342422 to
84bb7fd
Compare
zoewangg
approved these changes
Dec 6, 2018
spfink
force-pushed
the
finks/checksum-sse
branch
from
84bb7fd to
ffbcde4
Compare
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Aug 7, 2020
…527ecf33 Pull request: release <- staging/0c865dac-9ea8-4186-8ae1-9786527ecf33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 trailing checksums don't support SSE either.
Types of changes
Checklist
mvn installsucceedsLicense