Skip to content

Add flag to make sure we don't validate checksum twice #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

zoewangg
Copy link
Contributor

Description

Add checksumValidated flag to ChecksumValidatingInputStream to make s we don't validate twice

Motivation and Context

Fixes #873

Testing

All s3 integ tests passed

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from millems November 27, 2018 01:26
@zoewangg zoewangg force-pushed the zoewang-fixChecksumValidation branch from 7abf7ec to ece4aec Compare November 27, 2018 17:58
@zoewangg zoewangg merged commit 34a71cd into master Nov 27, 2018
@zoewangg zoewangg deleted the zoewang-fixChecksumValidation branch November 27, 2018 18:19
aws-sdk-java-automation added a commit that referenced this pull request Jun 11, 2020
…37ab9996

Pull request: release <- staging/2e905f54-630b-4334-a3e3-235537ab9996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1.0: Cannot Read S3 File Contents as InputStream Directly
2 participants