Apache configuration cleanup

[varunnvs92]

• Current Apache configuration options and default values seems fine (matches v1)
• Includes changes to support nonProxyHosts proxy configuration (v1 reference)

[millems]

Are there any other system properties we should support?

[millems]

Are our sync configurations consistent with async, or can they be updated to be more consistent?

[varunnvs92]

I don't see a lot of similarity between sync and async. The only options that match are connectionTimeout, maxConnections (renamed to maxConcurrency in async). I don't see any other related options.

ProxyConfiguration might makes sense for both sync/async but we don't currently have support for it and I am not sure which options in ProxyConfiguration can be applied to netty client as well.

[millems]

What about acquire timeout in async? Can that be controlled separately in sync?

[varunnvs92]

I see there is a "http.connection-manager.timeout" option in Apache but it only applicable for a specific implementation of apache client. It might not be applicable if we change the type of underlying apache client.

[millems]

Do we expect to ever change the underlying implementation, particularly to one that wouldn't support a similar setting? It would be nice to expose the async-equivalent features if we can.

[varunnvs92]

Makes sense. Added the option. Ah I really hate that Github doesn't allow replying to general comment directly.

[millems]

Nice! Are there any other async options we can also support, like max pending acquires, etc.?

[varunnvs92]

There is no max pending acquire option in apache. See this post. It applies to sync as well. AFAIK we have added all applicable options from SdkHttpConfigurationOption to the apache client.

We explicitly didn't want to add "TRUST_ALL_CERTIFICATES" option in either clients as it makes easy for customers to do the wrong thing.