Fix retrypolicy bug, see issue #646 #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
changed the title
shorea
reviewed
Aug 3, 2018
| @@ -54,7 +55,12 @@ private RetryPolicy(BuilderImpl builder) { | |||
| this.throttlingBackoffStrategy = builder.throttlingBackoffStrategy; | |||
| this.numRetries = builder.numRetries; | |||
| this.retryConditionFromBuilder = builder.retryCondition; | |||
| this.retryCondition = AndRetryCondition.create(MaxNumberOfRetriesCondition.create(numRetries), retryConditionFromBuilder); | |||
| if (numRetries == 0) { | |||
There was a problem hiding this comment.
RetryCondition.none() would be MaxNumberOfRetriesCondition(maxNumberOfRetries=0)
If we don't add the check here, it will add another duplicate condition MaxNumberOfRetriesCondition(maxNumberOfRetries=0)
RetryPolicy.none() would resolve to
AndRetryCondition(conditions=[MaxNumberOfRetriesCondition(maxNumberOfRetries=0), MaxNumberOfRetriesCondition(maxNumberOfRetries=0)])
Alternately, we can update AndRetryCondition to a Set instead of a list to fix this.
There was a problem hiding this comment.
hmm, seems like it will introduce another bug.
RetryPolicy.builder().numRetris(0).build() would still retry in this case.
I'll update the PR and use Set in AndReryCondition instead
spfink
approved these changes
Aug 8, 2018
zoewangg
force-pushed
the
zoewang-retryPolicyfix
branch
from
487b2f7 to
c34d885
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Oct 22, 2019
…017c41d5 Pull request: release <- staging/64ec41fe-a5f3-445a-83ca-6315017c41d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toString(),hashcode,equalsmethods to retry policy related classes.RetryPolicy.none()truly none retry policy.Currently,
RetryPolicy.none().retryCondition().toString()resolves to:and it should be