Make sure CRT resources are closed in tests #4753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang/crt-troubleshootleak
branch
from
7c0dbac to
5d41dcf
Compare
zoewangg
force-pushed
the
zoewang/crt-troubleshootleak
branch
from
5d41dcf to
5c5ce0d
Compare
davidh44
approved these changes
Dec 7, 2023
|
SonarCloud Quality Gate failed.
|
zoewangg
added a commit
that referenced
this pull request
Dec 15, 2023
* Synchronous CRT Http Client SPI with tests (#4405) * implemented synchronous crt java http client with tests. --------- Co-authored-by: Waqar Ahmed Khan <[email protected]> Co-authored-by: Dongie Agnir <[email protected]> * Various refactoring on CRT Sync HTTP Client (#4749) * Make sure CRT resources are closed (#4753) * Load HTTP implementations from classpath based on priority order (#4774) * Various performance optimization for CRT sync HTTP client (#4776) * Various performance optimization for CRT sync HTTP client * Return as soon as the stream starts if there is a payload in sync http client * Clean up tests and add changelog entry * Bump minor version to 2.22.0 * UrlConnectionSdkHttpService should have higher priority than AwsCrtSdkHttpService * Remove CrtResource.waitForNoResources() from integration tests because it increases test time and makes tests flaky especially when tests are running in parallel. We still verify it in wiremock tests and stability tests --------- Co-authored-by: Jonathan M. Henson <[email protected]> Co-authored-by: Waqar Ahmed Khan <[email protected]> Co-authored-by: Dongie Agnir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Make sure resources are closed in tests