-
Notifications
You must be signed in to change notification settings - Fork 914
Request compression trait #4371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7e19edd
Request compression: non-streaming operations (#4193)
davidh44 d9aa0de
Merge streaming branch into base branch (#4370)
davidh44 079242b
Add changelog
davidh44 0bde610
Remove unused imports
davidh44 3b2d92d
Update codegen test classes
davidh44 292b2ef
Remove old changelog
davidh44 fe18857
Refactor MockAsyncHttpClient
davidh44 90d70a8
Remove comments
davidh44 ef938d6
Fix assertion
davidh44 3fca02b
Address comments
davidh44 7bb4df6
Address comments
davidh44 f3a01c0
Address comments
davidh44 813e31d
Ensure container names are unique
davidh44 5baa869
Fix Checkstyle line length
davidh44 36764eb
Ensure container names are unique
davidh44 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"category": "AWS SDK for Java v2", | ||
"contributor": "", | ||
"type": "feature", | ||
"description": "Add support for RequestCompression trait to GZIP compress requests." | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
codegen/src/main/java/software/amazon/awssdk/codegen/compression/RequestCompression.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.codegen.compression; | ||
|
||
import java.util.List; | ||
import software.amazon.awssdk.annotations.SdkInternalApi; | ||
|
||
/** | ||
* Class to map the RequestCompression trait of an operation. | ||
*/ | ||
@SdkInternalApi | ||
public class RequestCompression { | ||
|
||
private List<String> encodings; | ||
|
||
public List<String> getEncodings() { | ||
return encodings; | ||
} | ||
|
||
public void setEncodings(List<String> encodings) { | ||
this.encodings = encodings; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
.../main/java/software/amazon/awssdk/codegen/poet/client/traits/RequestCompressionTrait.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.codegen.poet.client.traits; | ||
|
||
import com.squareup.javapoet.CodeBlock; | ||
import java.util.List; | ||
import java.util.stream.Collectors; | ||
import software.amazon.awssdk.codegen.model.intermediate.IntermediateModel; | ||
import software.amazon.awssdk.codegen.model.intermediate.OperationModel; | ||
import software.amazon.awssdk.core.client.handler.ClientExecutionParams; | ||
import software.amazon.awssdk.core.interceptor.SdkInternalExecutionAttribute; | ||
import software.amazon.awssdk.core.internal.interceptor.trait.RequestCompression; | ||
|
||
/** | ||
* The logic for handling the "requestCompression" trait within the code generator. | ||
*/ | ||
public class RequestCompressionTrait { | ||
|
||
private RequestCompressionTrait() { | ||
} | ||
|
||
/** | ||
* Generate a ".putExecutionAttribute(...)" code-block for the provided operation model. This should be used within the | ||
* context of initializing {@link ClientExecutionParams}. If request compression is not required by the operation, this will | ||
* return an empty code-block. | ||
*/ | ||
public static CodeBlock create(OperationModel operationModel, IntermediateModel model) { | ||
if (operationModel.getRequestCompression() == null) { | ||
return CodeBlock.of(""); | ||
} | ||
|
||
// TODO : remove once: | ||
// 1) S3 checksum interceptors are moved to occur after CompressRequestStage | ||
// 2) Transfer-Encoding:chunked is supported in S3 | ||
if (model.getMetadata().getServiceName().equals("S3")) { | ||
throw new IllegalStateException("Request compression for S3 is not yet supported in the AWS SDK for Java."); | ||
} | ||
|
||
List<String> encodings = operationModel.getRequestCompression().getEncodings(); | ||
|
||
return CodeBlock.builder() | ||
.add(CodeBlock.of(".putExecutionAttribute($T.REQUEST_COMPRESSION, " | ||
+ "$T.builder().encodings($L).isStreaming($L).build())", | ||
SdkInternalExecutionAttribute.class, RequestCompression.class, | ||
encodings.stream().collect(Collectors.joining("\", \"", "\"", "\"")), | ||
operationModel.hasStreamingInput())) | ||
.build(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.