Add a config option to allow users to enable post quantum TLS support in CRT HTTP client #3727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
commented
Jan 31, 2023
| } | ||
| } | ||
|
|
||
| private HttpMonitoringOptions revolveHttpMonitoringOptions(ConnectionHealthConfiguration config) { |
There was a problem hiding this comment.
No changes have been made to these methods. I just moved them to the new class.
alexw91
approved these changes
Jan 31, 2023
cenedhryn
reviewed
Jan 31, 2023
...-client/src/main/java/software/amazon/awssdk/http/crt/internal/AwsCrtConfigurationUtils.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private HttpMonitoringOptions revolveHttpMonitoringOptions(ConnectionHealthConfiguration config) { |
cenedhryn
approved these changes
Feb 1, 2023
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
TlsPreference API was removed as part of #3706. This PR adds support back through a different API
Modifications
Add a config option to allow users to enable post quantum TLS support in CRT HTTP client
Testing
Added unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License