IMDS Release #3725
Merged
IMDS Release #3725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Co-authored-by: Sai Chandupatla <[email protected]>
* Created the Configuration class for Ec2Metadata * Added CR comments in EndpointMode.java Co-authored-by: Sai Chandupatla <[email protected]>
* Implemented Happy Path client functionality along with Request Marshaller Class * Changed expected Exception message in Test Case * Incorporated PR feedback * Fixed SonarCloud Issues Co-authored-by: Sai Chandupatla <[email protected]>
) Co-authored-by: Sai Chandupatla <[email protected]>
* Implemented Response Handling and Parsing Methods for output * Added Javadoc info * Implemented PR comments * Changed dependency scope Co-authored-by: Sai Chandupatla <[email protected]>
* Implemented Retries functionality * Incorporated Code Review comments * Implemented PR Changes-2 * Adding CR review files * Implemented CR comments -4 * nit comment fixed Co-authored-by: Sai Chandupatla <[email protected]>
* Placed EndpointMode.java outside internal folder. Increased Test Coverage * Removed aws-json-protocol dependency * Added test cases for DocumentUnMarshaller Co-authored-by: Sai Chandupatla <[email protected]>
* Added Apache Client tests * Removed extra space in imds pom file * Removed duplicated cases as per PR comments * Removed duplicated cases as per PR comments Co-authored-by: Sai Chandupatla <[email protected]>
* IMDS Ec2 Metada refactoring * IMDS Ec2 Metada refactoring * IMDS Ec2 Metada refactoring * IMDS Ec2 Metada refactoring * IMDS Ec2 Metada refactoring * IMDS Ec2 Metada refactoring * IMDS Ec2 Metada refactoring * fix checkstyle error * Increase IMDS test code coverage
* IMDS Async client * Fix test classes * JavaDoc * PR comments and added IMDS to test-coverage-reporting - Create a common builder Ec2MetadataClientBuilder - Create a common test class BaseEc2MetadataClientTest - Refactor common initialization logic for both sync and async client in BaseEc2MetadataClient class - Use netty async client in unit tests - fix Async error logic * Improve JavaDoc and rename some variables - fix one failing unit test
* IMDS Async * IMDS Async client * Token caching in sync and async client and sync client unit test * Async token caching with retry * Temporarily remove AsyncClient token cache implementation - Pr comments * internal Api for token cache strategies
Async token cache implementation
* Surface area review - removed getters on client builder public interface - rename MetadataResponse to Ec2MetadataResponse - add builder-consumer for retry policy - add DefaultSdkAsyncHttpClientBuilder and DefaultSdkHttpClientBuilder to client builders - remove duplication in BaseEc2MetadataClient constructors - TokenResponseHandler cleanup - Updated ttl header logic if not found in response headers - use SdkHttpClient.Builder in IMDS Client Builder interface - Javadoc - Async Http Request Handlers refactor - add test for mutual exclusion of http client and http client builder in IMDS client builders - dont retry on bad response format from server
* feature changelog
dave-fn
reviewed
Jan 31, 2023
core/imds/src/main/java/software/amazon/awssdk/imds/Ec2MetadataClient.java
Outdated
Show resolved
Hide resolved
core/imds/src/main/java/software/amazon/awssdk/imds/Ec2MetadataRetryPolicy.java
Outdated
Show resolved
Hide resolved
core/imds/src/main/java/software/amazon/awssdk/imds/internal/RequestMarshaller.java
Outdated
Show resolved
Hide resolved
core/imds/src/main/java/software/amazon/awssdk/imds/Ec2MetadataClient.java
Outdated
Show resolved
Hide resolved
core/imds/src/main/java/software/amazon/awssdk/imds/Ec2MetadataClient.java
Outdated
Show resolved
Hide resolved
core/imds/src/main/java/software/amazon/awssdk/imds/Ec2MetadataResponse.java
Outdated
Show resolved
Hide resolved
Comment on lines
+76
to
+81
| public String toString() { | ||
| return "Ec2MetadataRetryPolicy{" + | ||
| "backoffStrategy=" + backoffStrategy.toString() + | ||
| ", numRetries=" + numRetries + | ||
| '}'; | ||
| } |
There was a problem hiding this comment.
Not a problem, can leave as is, but wanted to point out the ToString utils method.
core/imds/src/main/java/software/amazon/awssdk/imds/internal/Ec2MetadataEndpointProvider.java
Outdated
Show resolved
Hide resolved
dave-fn
approved these changes
Jan 31, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release IMDS feature to master branch
Closes Issue 61