Skip to content

CRT HTTP/1 GA - Surface Area Updates - Renaming #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

dave-fn
Copy link
Contributor

@dave-fn dave-fn commented Jan 23, 2023

Motivation and Context

PR in support for CRT HTTP/1 GA - Surface Area Updates. This PR renames several classes and methods.

Modifications

Renamed: ConnectionHealthChecksConfigurationConnectionHealthConfiguration
Renamed: allowableThroughputFailureIntervalminimumThroughputTimeout
Renamed: minThroughputInBytesPerSecondminimumThroughputInBps
Renamed: AwsCrtAsyncHttpClient.builder().connectionHealthChecksConfigurationAwsCrtAsyncHttpClient.builder().connectionHealthConfiguration

Testing

No new tests added.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dave-fn dave-fn requested a review from a team as a code owner January 23, 2023 22:35
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a changelog entry?

@dave-fn
Copy link
Contributor Author

dave-fn commented Jan 23, 2023

Can we add a changelog entry?

Absolutely. I thought one was not needed, which is why I didn't add it.

@dave-fn dave-fn force-pushed the davidfn/feature/crt/surface-area-updates branch 2 times, most recently from d00b9aa to 0b01a85 Compare January 24, 2023 00:11
@dave-fn dave-fn force-pushed the davidfn/feature/crt/surface-area-updates branch from 0b01a85 to 85ed233 Compare January 24, 2023 00:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dave-fn dave-fn merged commit b2aa3a0 into master Jan 24, 2023
@dave-fn dave-fn deleted the davidfn/feature/crt/surface-area-updates branch January 24, 2023 18:25
aws-sdk-java-automation added a commit that referenced this pull request Mar 4, 2025
…c2b589792

Pull request: release <- staging/9a52fe69-deb7-4248-853a-12dc2b589792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants