Skip to content

Remove @Ignore annotations for codegen metrics test #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Remove @Ignore annotations for codegen metrics test #3618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...src/test/java/software/amazon/awssdk/services/metrics/async/BaseAsyncCoreMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
import software.amazon.awssdk.metrics.MetricPublisher;
import software.amazon.awssdk.services.protocolrestjson.model.EmptyModeledException;

@Ignore
@RunWith(MockitoJUnitRunner.class)
public abstract class BaseAsyncCoreMetricsTest {
private static final String SERVICE_ID = "AmazonProtocolRestJson";
Expand All @@ -49,7 +48,6 @@ public abstract class BaseAsyncCoreMetricsTest {
static final int MAX_RETRIES = 2;
public static final Duration FIXED_DELAY = Duration.ofMillis(500);

@Ignore
@Test
public void apiCall_operationSuccessful_addsMetrics() {
stubSuccessfulResponse();
Expand All @@ -72,7 +70,6 @@ public void apiCall_operationSuccessful_addsMetrics() {
.isGreaterThanOrEqualTo(FIXED_DELAY);
}

@Ignore
@Test
public void apiCall_allRetryAttemptsFailedOf500() {
stubErrorResponse();
Expand All @@ -89,7 +86,6 @@ public void apiCall_allRetryAttemptsFailedOf500() {
capturedCollection.children().forEach(this::verifyFailedApiCallAttemptCollection);
}

@Ignore
@Test
public void apiCall_allRetryAttemptsFailedOfNetworkError() {
stubNetworkError();
Expand All @@ -115,7 +111,6 @@ public void apiCall_allRetryAttemptsFailedOfNetworkError() {
});
}

@Ignore
@Test
public void apiCall_firstAttemptFailedRetrySucceeded() {
stubSuccessfulRetry();
Expand Down