Skip to content

Removes @Ignore annotation from UrlConnHttpClient test because it's not needed #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Removes @Ignore annotation from UrlConnHttpClient test because it's not needed #3615

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67ec458
Removes @Ignore annotation from test because it's not needed
cenedhryn Dec 13, 2022
5cee39c
Merge branch 'master' into salande/remove-ignore-urlconn
cenedhryn Dec 14, 2022
5127280
Merge branch 'master' into salande/remove-ignore-urlconn
cenedhryn Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ...amazon/awssdk/http/urlconnection/UrlConnectionHttpClientWithCustomCreateWireMockTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,25 +45,24 @@ protected SdkHttpClient createSdkHttpClient(SdkHttpClientOptions options) {
}));
}

@Ignore // Not supported when using custom factory
// Empty test; behavior not supported when using custom factory
@Override
public void testCustomTlsTrustManager() {
}

@Ignore // Not supported when using custom factory
// Empty test; behavior not supported when using custom factory
@Override
public void testTrustAllWorks() {
}

@Ignore // Not supported when using custom factory
// Empty test; behavior not supported when using custom factory
@Override
public void testCustomTlsTrustManagerAndTrustAllFails() {
}

@Ignore
// Empty test; behavior not supported because the URL connection client does not allow disabling connection reuse
@Override
public void connectionsAreNotReusedOn5xxErrors() throws Exception {
// We cannot support this because the URL connection client doesn't allow us to disable connection reuse
}

@Test
Expand Down