Skip to content

Remove leading slash in header value for ARNs in CopySourceInterceptor #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2022
Merged

Remove leading slash in header value for ARNs in CopySourceInterceptor #3526

merged 2 commits into from
Nov 2, 2022

Conversation

dave-fn
Copy link
Contributor

@dave-fn dave-fn commented Oct 31, 2022

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dave-fn dave-fn requested a review from a team as a code owner October 31, 2022 17:46
zoewangg
zoewangg approved these changes Nov 1, 2022
View reviewed changes
.changes/next-release/bugfix-AWSSDKforJavav2-73c904b.json Outdated
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "AWS SDK for Java v2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: category should be Amazon S3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@dave-fn dave-fn force-pushed the features/CopySourceInterceptor-header-incorrect-ARN branch from ef1e624 to df47bc7 Compare November 2, 2022 16:50
@dave-fn dave-fn enabled auto-merge (squash) November 2, 2022 16:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dave-fn dave-fn merged commit cf81b6d into aws:master Nov 2, 2022
@dave-fn dave-fn deleted the features/CopySourceInterceptor-header-incorrect-ARN branch November 2, 2022 17:58
aws-sdk-java-automation added a commit that referenced this pull request Dec 20, 2024
@aws-sdk-java-automation
Merge pull request #3526 from aws/staging/28ead09b-111d-438f-9879-4bd…
4159b5a 
…74d3aacbe

Pull request: release <- staging/28ead09b-111d-438f-9879-4bd74d3aacbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoewangg zoewangg zoewangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dave-fn @zoewangg