Skip to content

Add support for Endpoints 2.0 #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Add support for Endpoints 2.0 #3502

merged 9 commits into from
Oct 20, 2022

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 19, 2022

Motivation and Context

New SDK feature.

Modifications

This release updates internal logic for constructing API endpoints.

We have added rule-based endpoint providers. Additionally there are new
interfaces for endpoint providers and parameters at the service client level.

The SDK provides service-specific `EndpointProvider` interfaces (e.g.
`S3EndpointProvider`), that have a single method `resolveEndpoint`.
`resolveEndpoint` accepts a set of parameters (also service specific) and
computes an endpoint based on those parameters. All clients have a default
implementation, but users are free to implement these to customize their
endpoint logic.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

This release updates internal logic for constructing API endpoints.

We have added rule-based endpoint providers. Additionally there are new
interfaces for endpoint providers and parameters at the service client level.

The SDK provides service-specific `EndpointProvider` interfaces (e.g.
`S3EndpointProvider`), that have a single method `resolveEndpoint`.
`resolveEndpoint` accepts a set of parameters (also service specific) and
computes an endpoint based on those parameters. All clients have a default
implementation, but users are free to implement these to customize their
endpoint logic.
@dagnir dagnir force-pushed the dongie/e2-public-merge branch from 0f5f5bd to a7f7204 Compare October 19, 2022 23:45
@dagnir dagnir marked this pull request as ready for review October 19, 2022 23:46
@dagnir dagnir requested a review from a team as a code owner October 19, 2022 23:46
@dagnir
Copy link
Contributor Author

dagnir commented Oct 20, 2022

The GitHub workflow jobs AWS CodeBuild CI / jdk11-build (pull_request) and AWS CodeBuild CI / sonar-cloud-build (pull_request) seem to have timed out, but the codebuild jobs themselves succeeded. Will follow up with updating the timeout for the actions.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 125 Code Smells

69.8% 69.8% Coverage
0.6% 0.6% Duplication

@dagnir dagnir merged commit 40b8869 into master Oct 20, 2022
@dagnir dagnir deleted the dongie/e2-public-merge branch October 20, 2022 20:32
@joviegas joviegas mentioned this pull request Aug 18, 2023
aws-sdk-java-automation added a commit that referenced this pull request Dec 4, 2024
…df675f26e

Pull request: release <- staging/3923c51c-9fc3-4400-ba08-764df675f26e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants