Updated aws-crt-client to use new 'utils' publishers for its response body logic. #3490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body logic. Added a new publisher to 'utils': SimplePublisher - A publisher that exposes simple `write`, `complete` and `error` methods, and avoids the caller needing to be concerned about backpressure or following the reactive streams specification.
zoewangg
reviewed
Oct 17, 2022
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Show resolved
Hide resolved
...ient/src/main/java/software/amazon/awssdk/http/crt/internal/response/CrtResponseAdapter.java
Show resolved
Hide resolved
...ient/src/main/java/software/amazon/awssdk/http/crt/internal/response/CrtResponseAdapter.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Oct 18, 2022
...ient/src/main/java/software/amazon/awssdk/http/crt/internal/response/CrtResponseAdapter.java
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/async/SimplePublisher.java
Show resolved
Hide resolved
millems
force-pushed
the
millem/crt-cleanup-3
branch
from
6326556 to
6121ec7
Compare
millems
force-pushed
the
millem/crt-cleanup-3
branch
from
6121ec7 to
c695e0a
Compare
zoewangg
approved these changes
Oct 19, 2022
|
Integration and stability tests are passing. I'll be baking this in the canaries for a little while to build additional confidence before merging to main. |
|
Kudos, SonarCloud Quality Gate passed! |
joviegas
approved these changes
Oct 20, 2022
|
Looks good after baking in the canaries for a few days. Slight heap memory usage increase, but no latency impact or increase in errors. |
millems
added a commit
that referenced
this pull request
Oct 21, 2022
…#3507) * Updated aws-crt-client to use new 'utils' publishers for its request body logic. Added two new publishers to 'utils': 1. StoringSubscriber - A subscriber that stores the events it receives in memory for retrieval. 2. ByteBufferStoringSubscriber - A subscriber that stores byte buffers it recevies in memory for retrieval. * Updated aws-crt-client to use new 'utils' publishers for its response body logic. (#3490) * Updated aws-crt-client to use new 'utils' publishers for its response body logic. Added a new publisher to 'utils': SimplePublisher - A publisher that exposes simple `write`, `complete` and `error` methods, and avoids the caller needing to be concerned about backpressure or following the reactive streams specification. * Addressed comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new publisher to 'utils': SimplePublisher - A publisher that exposes simple
write,completeanderrormethods, and avoids the caller needing to be concerned about backpressure or following the reactive streams specification.