Skip to content

Fix handling of FIPS pseudo regions #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 5, 2022
Merged

Fix handling of FIPS pseudo regions #3460

merged 8 commits into from
Oct 5, 2022

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 4, 2022 •
edited
Loading

Motivation and Context

Compliant with SDK standard behavior.

Modifications

This commit adds support for automatically transforming a FIPS pesudo region (e.g. "fips-us-west-2"), into a standard region name + setting the fips_enabled flag to true.

Testing

New unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
Fix handling of FIPS pseudo regions
d21bb63 
This commit adds support for automatically transforming a FIPS pesudo region
(e.g. "fips-us-west-2"), into a standard region name + setting the fips_enabled
flag to true.
@dagnir dagnir requested a review from a team as a code owner October 4, 2022 18:41
@dagnir dagnir enabled auto-merge (squash) October 5, 2022 20:02
@dagnir dagnir disabled auto-merge October 5, 2022 20:02
@dagnir dagnir enabled auto-merge (squash) October 5, 2022 20:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dagnir dagnir merged commit 897bbde into master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millems millems millems left review comments

@cenedhryn cenedhryn cenedhryn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagnir @millems @cenedhryn