Skip to content

Enable configuration of the connection timeout for AwsCrtAsyncHttpClient #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

L-Applin
Copy link
Contributor

@L-Applin L-Applin commented Oct 3, 2022

Motivation and Context

This pull-request intent is to resolve #3251

Modifications

Update the AwsCrtAsyncHttpClient.Builder class with a method to set the connection timeout. If not specified, will default to the value in SdkHttpConfigurationOption.GLOBAL_HTTP_DEFAULTS which is 2 seconds. This change will therefore overwrite the default value of 3 seconds specified in the SocketOption.

Testing

Created new unit test to validate field was set correctly.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@L-Applin L-Applin requested a review from a team as a code owner October 3, 2022 17:00
@L-Applin L-Applin force-pushed the olapplin/crt-http-timeout branch from be5bb1f to 33775c3 Compare October 3, 2022 17:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@L-Applin L-Applin requested a review from dagnir October 3, 2022 19:10
@nikp
Copy link
Contributor

nikp commented Oct 4, 2022

@L-Applin brought this to my attention: #3457 supercedes this now because it also allows KeepAlive override (which is needed to maintain long-running connections)

@L-Applin L-Applin closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AwsCrtAsyncHttpClient - Support customization of connectionTimeout
3 participants