Use RFC 822 format for marshalling date shapes #3452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
reviewed
Oct 3, 2022
| .appendLiteral(' ') | ||
| .appendOffset("+HHMM", "GMT") | ||
| .toFormatter() | ||
| .withLocale(Locale.US); |
There was a problem hiding this comment.
- I guess the reason for Locale.US is V1-refernce, correct me if I am wrong.
- Why are we not doing
toFormatter(ResolverStyle.SMART, IsoChronology.INSTANCE)
same as done in RFC_1123_DATE_TIME ?
There was a problem hiding this comment.
I guess an alternative would be to set the ResolverStye.SMART and IsoChonology.INSTANCE values on the DateTimeFormatter object after it's been built. Let me know if you'd prefer me to make that change.
There was a problem hiding this comment.
Yeap , we can set it after its been built.
Can we add some test cases where we can test this too (ResolverStye and IsoChonology)?
We can compare the same with RFC_1123_DATE_TIME
joviegas
approved these changes
Oct 4, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility method so that dates are marshalled using RFC 822 format.
Motivation and Context
The formatted representation of dates with single-digit day of month also includes a single-digit. This code fix will change the representation to two-digit day of month.
Current:
Expected:
Modifications
Modified DateUtils.java to add parse and format methods specific to RFC 822. Cascaded these changes to other modules.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License