Skip to content

Make WebIdentityTokenFileCredentialsProvider implement AutoCloseable #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Make WebIdentityTokenFileCredentialsProvider implement AutoCloseable #3440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...java/software/amazon/awssdk/auth/credentials/WebIdentityTokenFileCredentialsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
import software.amazon.awssdk.auth.credentials.internal.WebIdentityCredentialsUtils;
import software.amazon.awssdk.auth.credentials.internal.WebIdentityTokenCredentialProperties;
import software.amazon.awssdk.core.SdkSystemSetting;
import software.amazon.awssdk.utils.IoUtils;
import software.amazon.awssdk.utils.SdkAutoCloseable;
import software.amazon.awssdk.utils.ToString;
import software.amazon.awssdk.utils.builder.CopyableBuilder;
import software.amazon.awssdk.utils.builder.ToCopyableBuilder;
Expand All @@ -44,7 +46,7 @@
*/
@SdkPublicApi
public class WebIdentityTokenFileCredentialsProvider
implements AwsCredentialsProvider,
implements AwsCredentialsProvider, SdkAutoCloseable,
ToCopyableBuilder<WebIdentityTokenFileCredentialsProvider.Builder, WebIdentityTokenFileCredentialsProvider> {

private final AwsCredentialsProvider credentialsProvider;
Expand Down Expand Up @@ -125,6 +127,11 @@ public Builder toBuilder() {
return new BuilderImpl(this);
}

@Override
public void close() {
IoUtils.closeIfCloseable(credentialsProvider, null);
}

/**
* A builder for creating a custom {@link WebIdentityTokenFileCredentialsProvider}.
*/
Expand Down