Skip to content

Clarify error message in Runnable Request #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Aug 30, 2022

Replacing "pool lease timeout" with "connection acquisition timeout"

Motivation and Context

"Pool lease timeout" is ambiguous in error message for too many acquire operations in Runnable Request class

Modifications

Updating error message to clearly state "connection acquisition timeout"

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

…timeouts

Replacing "pool lease timeout" with "connection acquisition timeout"
@davidh44 davidh44 requested a review from a team as a code owner August 30, 2022 23:21
Changing "slowing" to "slow"
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davidh44 davidh44 merged commit deeb397 into master Aug 31, 2022
@davidh44 davidh44 deleted the hdavidh/updateRunnableRequestErrorMsg branch August 31, 2022 20:37
@zoewangg
Copy link
Contributor

@all-contributors please add @davidh44 for code.

@allcontributors
Copy link
Contributor

@zoewangg

I've put up a pull request to add @davidh44! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants